Add prerelease flag to download #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a comment to this issue in CLDR's bug tracker. |
dpad46
force-pushed
the
dpad46/prerelease-download
branch
from
cef7db1
to
4c8aa5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add a prerelease flag to
thor cldr:downloadto quickly test prerelease versions of cldr from sources such as this one.What approach did you choose and why?
Prerelease versions of cldr contain needed files under
production/, which differs from the directory structure of released versions. This means that in order to test them, they must be manually downloaded and parsed tovendor/.As a solution, a separate
download#download_prereleasefunction has been added that only extractsproduction/from a given source, such that the files extracted tovendor/result in the expected directory structure.What should reviewers focus on?
Prereleases in https://github.com/unicode-org/cldr-staging/releases are very large (~1.5gb). In the future it would be nice to find a way to only download needed files as the large majority of the compressed file consists of documentation.
The impact of these changes
By regularly testing prerelease versions of cldr, preparations for upcoming changes can be made, allowing for quicker upgrades to released versions.
Testing
Manually checked that file is properly extracted to
vendor/, and that the extracted files are used as expected.Checklist